<div dir="ltr"><div><div><div><div><div><div><div><div><div><div>Hi Michael,<br><br></div> You're using the scifio-bf-compat snapshot right?<br><br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
- we had to add two services to our Scifio Context OMEXMLMetadataService.class, OMEXMLService.class<br></blockquote><br></div> Curtis and I talked about a Service solution.. it should be fairly straightforward, just have to do it!<br>
<br><br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
One other small bug: the OMEMetadata empty constructor is broken<br> <br></blockquote><br></div> Yeah, Curtis made the @Parameter injection smarter for Scijava-common, but it means no more null contexts allowed. I will fix that, thanks for pointing it out!<br>
<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">- but this does not work for jpg images (index out of bounds)<br></blockquote><br></div>where do you get this exception? I'll write some calibration unit tests today to try and cover these scenarios.<br>
<br></div>Also, where is your calibration data coming from exactly? I don't believe there's any metadata in JPEG that's explicitly being translated to calibration values. So currently the expected behavior would be to see default calibration (1.0um) for each axis.<br>
<br></div>Still, setting the calibration after initializing Metadata should work.. can you share the code snippet that's doing the setting?<br><br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
- and I have at least one .lsm image that fails with a null pointer if I load it with .openImg.<br>
This error is not related to our attemps to get callibration working<br>
(img in the appendix)<br></blockquote><br></div>Thanks for providing the failing image. I'll test that today.<br><br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
I looked today at the interval selection code. Could you add a long[]
constructor for DimRange? I think a simple one that just lists all
included indices should be enough (equivalent to the string constructor
with "a,b,c,d" long[] {a,b,c,d})<br></blockquote><br></div>Yep, that sounds reasonable :) I may release a 0.5.2 today because of some ImgSaver bug fixes I made yesterday.. so if so, this will be included as well.<br>
<br></div>Thanks for the feedback,<br></div>Mark<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 15, 2013 at 7:48 AM, Michael Zinsmaier <span dir="ltr"><<a href="mailto:michael.zinsmaier@gmx.de" target="_blank">michael.zinsmaier@gmx.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mark,<br>
<br>
yay the new libs (currently scifio-bf-compat 1.0.1 / scifio-0.5.1 / scijava-common-2.0.2) are working (-:<br>
<br>
Callibration still makes some trouble (I know that is super early implementation stage but anyways)<br>
- we had to add two services to our Scifio Context OMEXMLMetadataService.class, OMEXMLService.class<br>
- the ImgPlus returned by ImgOpener.openImg does not contain callibration values<br>
<br>
because of the 2nd point we added a small hack: we currently add the calibration values after loading of the image (calibration values<br>
come from metadata -> ome metadata)<br>
<br>
- but this does not work for jpg images (index out of bounds)<br>
<br>
- and I have at least one .lsm image that fails with a null pointer if I load it with .openImg.<br>
This error is not related to our attemps to get callibration working<br>
(img in the appendix)<br>
<br>
<br>
<br>
One other small bug: the OMEMetadata empty constructor is broken<br>
<br>
OMEMEtadata() -> this(null)<br>
OMEMetadata(final Context context) -> this(context, null);<br>
OMEMetadata(final Context context, final OMEXMLMetadata root) -> setContext(context)<br>
context.inject(this);<br>
<br>
=> NullPointer<br>
<br>
<br>
And finally a feature request:<br>
I looked today at the interval selection code. Could you add a long[] constructor for DimRange? I think a simple one that just lists all included indices should be enough (equivalent to the string constructor with "a,b,c,d" long[] {a,b,c,d})<br>
<br>
Best regards<span class="HOEnZb"><font color="#888888"><br>
Michael<br>
<br>
<br>
<br>
</font></span></blockquote></div><br></div>